ejabberd - Comments for "Roster Subscription Problem"

right, that's where it

guntanis — Tue, 13 Mar 2007 20:52:46 +0000

right, that's where it becomes not RFC Compliant:

RFC 3921
Page: 32
Section: 8.1
The server MUST NOT send presence subscription requests or roster
pushes to unavailable resources, nor to available resources that have
not requested the roster.

Basically what ejabberd is doing is:
1. client1 sends a subscription request to client2
2. server pushes client1 to client2's roster with subscription none. [while client2 didn't request it.]

The problem is that ejabberd

teo — Tue, 13 Mar 2007 17:07:38 +0000

The problem is that ejabberd stores incoming subscription requests in users' rosters. So, if you want to fix it you have to store them somwhere else (in a separate table).

True

guntanis — Mon, 12 Mar 2007 23:50:06 +0000

True,
For some reason when I tested it the first time it worked. Later on I tried and didn't work.
I'm trying to make it work, if anyone of you has any pointers please let me know.
If I get it to work, I'll post the _real_ fix :P

Thanks

Jorge

The only impact of this

teo — Fri, 09 Mar 2007 10:51:49 +0000

The only impact of this "fix" is that clients will never get or set roster items.

thank you !

mremond — Fri, 09 Mar 2007 08:48:44 +0000

Hello,

Thank you. We will have a look at this code and we will make some more testing with various client on it.

--
Mickaël Rémond
Process-one

Fixed.

guntanis — Fri, 09 Mar 2007 00:04:51 +0000

mod_roster.erl
Current Code:

-ifdef(PSI_ROSTER_WORKAROUND).

process_iq(From, To, IQ) ->
    #iq{sub_el = SubEl} = IQ,
    #jid{lserver = LServer} = From,
    case lists:member(LServer, ?MYHOSTS) of
        true ->
            ResIQ = process_local_iq(From, To, IQ),
            ejabberd_router:route(From, From,
                                  jlib:iq_to_xml(ResIQ)),
            ignore;
        _ ->
            IQ#iq{type = error, sub_el = [SubEl, ?ERR_ITEM_NOT_FOUND]}
    end.

-else.

CODE THAT FIX THE BEHAVIOR DESCRIBED IN THE LAST POST

-ifdef(PSI_ROSTER_WORKAROUND).

process_iq(From, To, IQ) ->
    #iq{sub_el = SubEl} = IQ,
    #jid{lserver = LServer} = From,
    case lists:member(LServer, ?MYHOSTS) of
        true ->
            ResIQ = process_local_iq(From, To, IQ),
            ejabberd_router:route(From, To,
                                  jlib:iq_to_xml(ResIQ)),
            ignore;
        _ ->
            IQ#iq{type = error, sub_el = [SubEl, ?ERR_ITEM_NOT_FOUND]}
    end.

-else.

This might help someone in the future, I don't know if psi will behave correctly, but this will make it RFC compliant.

Cheers!
Jorge Guntanis