ejabberd - Comments for "avatar not recognised by client"

Re: avatar not recognised by client

xram@jabber.ru — Tue, 25 Mar 2008 14:27:38 +0000

Right, the value is stored in base64, so, here is a problem: what happens if we will not encode the data with base64, but the data is stored in raw binary (not base64)? For example, my OpenLDAP stores avatars in raw binary.

Recovered, check binvalues.txt

mfoss — Tue, 25 Mar 2008 09:09:04 +0000

xram@jabber.ru wrote:

could you show the whole data in PHOTO element?

Vetetix provided the whole binary data in his original message. But I removed the binary content and left only a few characters because the text was completely unreadable.

I recovered the binary content from a backup, check the file binvalues.txt.

Re: avatar not recognised by client

xram@jabber.ru — Tue, 25 Mar 2008 02:22:50 +0000

vetetix wrote:

The avatars are stored in base64 encoding in openldap

Are you sure about that? It is a stupid idea to store binary data in base64 encoding in openldap.
Anyway, could you show the whole data in PHOTO element?

ejabberd reencodes to base64

mfoss — Mon, 24 Mar 2008 12:08:20 +0000

vetetix wrote:

The avatars are stored in base64 encoding in openldap

Looking at ejabberd source code, when the file mod_vcard_ldap.erl is preparing the vcard to send to the client, it runs this:

ldap_attribute_to_vcard(vCard, {"photo", Value}) ->
    {xmlelement,"PHOTO",[],[
	{xmlelement,"BINVAL",[],[{xmlcdata, jlib:encode_base64(Value)}]}]};

It seems that ejabberd reencodes again the image.

You can try this modification:

ldap_attribute_to_vcard(vCard, {"photo", Value}) ->
    {xmlelement,"PHOTO",[],[
	{xmlelement,"BINVAL",[],[{xmlcdata, Value}]}]};

Its me again, but logged in

vetetix — Mon, 24 Mar 2008 02:29:17 +0000

Its me again, but logged in this time.

The avatars are stored in base64 encoding in openldap, and not through a link to a file on the hard drive, could it be why there is a problem ?