ejabberd - Comments for "Extending MOD_XMLRPC functionality"

Patch committed to mod_xmlrpc and mod_muc_admin SVN

mfoss — Tue, 06 May 2008 15:40:46 +0000

Hi, thanks for the patch. I finally decided how to apply it.

I made some changes:

The functions related to MUC administration are moved to mod_muc_admin. You need to download and install that module. You don't need to enable the module in ejabberd.cfg to use those functions, as they are simply called as a library.
The Erlang function delete_room is renamed to destroy_room
The create function now reads the default settings from the vhost expected (ServerHost), not from the first vhost (?MYSERVER)
The name of the parameters to create/destroy room were [room, server, vhost], and now they are: [name, service, server]. The meaning is still the same:
- name of the room
- MUC service where the room is created/destroyed
- Jabber server where the MUC service is hosted
If the room already exists during creation, or doesn't exist during deletion, the call returns 1.

I noticed that the mod_xmlrpc.erl file is in DOS format, and has ugly character at the end of lines. I would like to fix that file, but I prefer to wait until you finish modidying it, so your patches apply cleanly.

Mod_xmlrpc svn patch and full file

darren.ferguson — Thu, 24 Apr 2008 17:19:36 +0000

Badlop per our discussion the svn diff file can be found for the mod_xmlrpc here

https://support.openband.net/pub/mod_xmlrpc.erl.patch

The full mod_xmlrcp file i was working on can be found here.

https://support.openband.net/pub/mod_xmlrpc.erl

I changed the way the group chat muc was added so that we do not need to restart the mod_muc in order for the new room to be displayed.

I am working on some more commands that can be utilized over xmlrpc and will post the diffs and files once i have them working correctly.

You can upload the file or

mfoss — Mon, 21 Apr 2008 20:55:16 +0000

You can upload the file or files anywhere you want, and tell here the link. Or you can put the content in a comment.

mod_xmlrpc additions

darren.ferguson — Mon, 21 Apr 2008 19:53:22 +0000

Badlop, thanks again for pointing me in the right direction, i have the add group and remove group working in the server per virtual host.

If you can let me know how you wish the code changes i can make that, currently i put them as an svn diff patch based off r554 of the current ejabberd modules.

Will now look into the other piece of having users added to the whitelist etc.

Badlop, thank you

darren.ferguson — Mon, 21 Apr 2008 15:18:17 +0000

Thank you for the answers that is very helpful, if you wish i can send you the diff files for the code i have created for the mod_xmlrpc if you wish in order that it can be put into the svn for the module. If not, please let me know how you wish me to publish and i will do that.

For the other pieces thank you for the information i will check those out and determine how to implement into the mod_xmlrpc portions.

For the change_config and get_config i will check through these functions and determine how they work and how too get what is needed for the white list.

Thanks again for the information, will await your reply for the module information regarding the mod_xmlrpc changes.

darren.ferguson wrote: I am

mfoss — Sun, 20 Apr 2008 18:20:30 +0000

darren.ferguson wrote:

I am wondering if they will be of any use to anyone regarding the module.

If you publish the code, I will include in SVN.

darren.ferguson wrote:

On another node, i am trying to add the following functionality to the module but have so far came up with nothing:
1. Creating a new MUC group on the server.
2. Destroying an MUC group on the server.

I recently implemented a similar thing in mod_muc_admin. In my case the purpose was to define rooms to create or destroy in a text file and to be called with a shell command. You can use the code as example.

The functions are:
1. muc_create_file(Filename)
2. muc_destroy_file(Filename)

I don't remember if it's required to restart mod_muc in some case for the changes to take effect.

darren.ferguson wrote:

3. Adding a JID to the whitelist of an MUC.
4. Removing a JID from the whitelist of an MUC.

In mod_muc_room.erl I see get_config and change_config, but I don't remember using this, so I don't have example code to show you. And it would take too much time to explain how to use them.