ejabberd - Comments for "custom mod_roster"

Did you ever complete your

wpK — Sat, 13 Nov 2010 01:55:27 +0000

Did you ever complete your custom mod_roster? I'm also making a similar change currently and need to add an attribute to the roster item as well as add an attribute to the that the items are within. I'm hoping to not have to make a copy of mod_roster but it looks like the only choice.

Thanks.

Oh I see

Tronman — Tue, 09 Mar 2010 16:51:26 +0000

Ah, yes that makes sense. The record isn't going to be a valid roster record since I changed the definition of the type so the record it was loading from the roster table didn't match. Turns out what I was trying before (recreating the DB and make clean) was individually insufficient, I had to do both a full rebuild with make clean and recreate the database, and now I've got a new column in the roster table I can change! Neat, though I still have a ways to go.

I noticed that using xs, it tries to append the element as a whole new XML tag. Maybe I should have been more clear before, I'm actually trying to add some attributes to an item tag, e.g. <item jid="bla" myattrib="nifty">...etc. I'm not sure if xs will work for that seems it to want a new element altogether.

I'm hoping using a custom element in the "roster" record, and experimenting with item_to_xml will help, but I'll be posting back here if I run into more issues.

Thanks for your help!

I isn't a valid roster record

mfoss — Tue, 09 Mar 2010 10:51:33 +0000

Quote:

the line "J = element(3, I#roster.usj)". If I understand my erlang (which I may not), this should just be assigning J the 3rd element of the tuple usj in I which is a roster. I don't see how adding an element to the roster would effect that.

That line:
1. checks if I is a 'roster' valid record as defined in the module binary
2. gets the element 'usj' of the record
3. as usj is a tuple with three elements, then it gets the third element (the JID)

If that line generates the error {badrecord,roster}, it means I isn't a valid 'roster' record. Maybe it is a string, or an atom, or an invalid 'roster' record (generated by a module that has a different definition of the record).

No Luck

Tronman — Mon, 08 Mar 2010 14:30:58 +0000

Hey,

That was a good idea, especially after I noticed the error pops up in mod_shared_roster as well, unfortunately no luck. I'm still getting the same error message about bad records even after a total rebuild.

It seems to be having a problem with fill_subscription_lists, specifically at the line "J = element(3, I#roster.usj)". If I understand my erlang (which I may not), this should just be assigning J the 3rd element of the tuple usj in I which is a roster. I don't see how adding an element to the roster would effect that.

The other places it complains about bad elements seems to be in "mod_shared_roster/get_user_roster" and "get_in_pending_subscriptions", which do indeed do some alternations to roster records but nothing popping out at me that would cause an issue.

Anything other suggestions, please let me know. I'll keep investigating in the meantime, and might try changing the xs field as you suggested. Thanks.

The 'roster' record is used

mfoss — Sat, 06 Mar 2010 09:40:11 +0000

The 'roster' record is used by several modules. When you modify the record definition, better you run "make clean; make" to ensure all the files are recompiled.

Alternatively, maybe you can include your extended elements in the 'xs' field of the 'roster' record, which means you don't need to change the record definition, only to fill that field with your desired data.