We are compiling ejabberd 17.9 using Erlang OTP 20 and Elixir 1.5.2.
We are getting the following error when we try to use mod_muc_admin to remove unused rooms with [history_size > 0]
:mod_muc_admin.rooms_unused_list("global", 1)
** (FunctionClauseError) no function clause matching in :calendar.datetime_to_gregorian_seconds/1
The following arguments were given to :calendar.datetime_to_gregorian_seconds/1:
# 1
{1513, 700515, 685388}
(stdlib) calendar.erl:137: :calendar.datetime_to_gregorian_seconds/1
I suspect this is related to Erlang/Elixir versions, but I did not found any official documentation that states any problem with the versions we are using.
The documentation of the erlang source code states:
Erlang/OTP 17.5 or higher.
Any thoughts?
Best regards,
Marcelo Flores Manrique
I can reproduce that crash,
I can reproduce that crash, and fixed it in this recent commit:
The second commit
The second commit (...) seems to have fixed the issue. Thanks!
We also want to start contributing with the ejabberd community pushing some corrections. Where can we find guidelines to do so?
The second commit
The second commit () seems to have fixed the issue. Thanks!
We also want to start contributing with the ejabberd community pushing some corrections. Where can we find guidelines to do so?
I think there aren't written
I think there aren't written guidelines specific to ejabberd. Basically, try to change only the source code lines strictly required for your changes. Split changes related to different topics in different commits. Indent the code following the emacs standard (well, I use Vim, but try to follow the appearance of the existing code).
In your first push, mention that this is your first contribution, and request any suggestion to do it better in the future ;)
Thanks! we are eager to start
Thanks! we are eager to start contributing