New hooks for mod_pubsub

Right, the best way would be to run two new hooks in mod_pubsub.

The improvement looks useful. Once you have a patch that you like, you can create a ticket in the bug tracker describing the problem and attaching your patch as a proposed solution.

Here's a preliminary implementation. I didn't test it.

--- mod_pubsub/mod_pubsub.erl
+++ mod_pubsub/mod_pubsub.erl
@@ -1783,13 +1783,16 @@ create_node(Host, ServerHost, Node, Owner, GivenType, Access, Configuration) ->
 	    case transaction(CreateNode, transaction) of
 		{result, {NodeId, SubsByDepth, {Result, broadcast}}} ->
 		    broadcast_created_node(Host, Node, NodeId, Type, NodeOptions, SubsByDepth),
+		    ejabberd_hooks:run(pubsub_create_node, ServerHost, [ServerHost, Host, NodeId, NodeOptions, SubsByDepth]),
 		    case Result of
 			default -> {result, Reply};
 			_ -> {result, Result}
 		    end;
-		{result, {_NodeId, _SubsByDepth, default}} ->
+		{result, {NodeId, SubsByDepth, default}} ->
+		    ejabberd_hooks:run(pubsub_create_node, ServerHost, [ServerHost, Host, NodeId, NodeOptions, SubsByDepth]),
 		    {result, Reply};
-		{result, {_NodeId, _SubsByDepth, Result}} ->
+		{result, {NodeId, SubsByDepth, Result}} ->
+		    ejabberd_hooks:run(pubsub_create_node, ServerHost, [ServerHost, Host, NodeId, NodeOptions, SubsByDepth]),
 		    {result, Result};
 		Error ->
 		    %% in case we change transaction to sync_dirty...
@@ -1834,6 +1837,7 @@ delete_node(Host, Node, Owner) ->
 		    end
 	     end,
     Reply = [],
+    ServerHost = dumb_get_serverhost(Host),
     case transaction(Host, Node, Action, transaction) of
 	{result, {_, {SubsByDepth, {Result, broadcast, Removed}}}} ->
 	    lists:foreach(fun({RNode, _RSubscriptions}) ->
@@ -1843,23 +1847,31 @@ delete_node(Host, Node, Owner) ->
 		Options = RNode#pubsub_node.options,
 		broadcast_removed_node(RH, RN, NodeId, Type, Options, SubsByDepth)
 	    end, Removed),
+	    ejabberd_hooks:run(pubsub_delete_node, ServerHost, [ServerHost, Host, Node]),
 	    case Result of
 		default -> {result, Reply};
 		_ -> {result, Result}
 	    end;
 	{result, {_, {_, {Result, _Removed}}}} ->
+	    ejabberd_hooks:run(pubsub_delete_node, ServerHost, [ServerHost, Host, Node]),
 	    case Result of
 		default -> {result, Reply};
 		_ -> {result, Result}
 	    end;
 	{result, {_, {_, default}}} ->
+	    ejabberd_hooks:run(pubsub_delete_node, ServerHost, [ServerHost, Host, Node]),
 	    {result, Reply};
 	{result, {_, {_, Result}}} ->
+	    ejabberd_hooks:run(pubsub_delete_node, ServerHost, [ServerHost, Host, Node]),
 	    {result, Result};
 	Error ->
 	    Error
     end.
 
+%% "pubsub.localhost.pubsub.example.org" --> "localhost.pubsub.example.org"
+dumb_get_serverhost(Host) ->
+    string:join(string:substr(string:tokens(Host, "."), 2), ".").
+
 %% @spec (Host, Node, From, JID, Configuration) ->
 %%		  {error, Reason::stanzaError()} |
 %%		  {result, []}